#72 ✓resolved
joep

A couple of file tab enhancements...

Reported by joep | August 10th, 2010 @ 01:14 PM

Attached is a couple of minor enhancements I made to the files tab.

  1. When a new folder is created, the folder owner was not recorded, resulting in 'Unknown' being listed as the owner in the folder details.

  2. In the tree display in the left-hand pane, 'Domain Root' could only be selected by clicking on the itty-bitty icon, but not on the title (as with every other item in the tree).

  3. When a folder was selected in the tree, 'Make archive' and 'Delete' appeared in the far right pane, even though they didn't work. They appear to only work on a selected item in the middle pane. They are removed when no item is selected. I believe this is the subject of an earlier ticket (#36).

Joe

Comments and changes to this ticket

  • joep

    joep August 10th, 2010 @ 01:54 PM

    I'm not totally sure why 'Domain Root' is handled as a special case. Other than the little icon, which makes perfect sense, shouldn't it just be another folder, with the details showing up in the right pane like the others, and even rename-able?

  • joep

    joep August 10th, 2010 @ 06:04 PM

    The third problem (regarding ticket #36) is not really solved by my patch, but there is some fairly unpredictable behavior as things currently stand. To observe: go to a tree element in the left pane that contains files and/or folders, select one of the folders or files in the center pane, and then switch to a different tree element in the left pane. No elements in the center pane will be selected, but clicking delete will delete the item you selected previously.

  • joep

    joep August 10th, 2010 @ 08:02 PM

    Resetting the selection to the current node when it is selected seems to solve the problem. A patch is attached.

  • Pascal Rettig

    Pascal Rettig August 11th, 2010 @ 10:33 AM

    Hi Joe,

    Thanks for the patches - I'll integrate them today - The File manager issue #3 is a known bug that we'll fix this week.

  • Pascal Rettig

    Pascal Rettig August 11th, 2010 @ 06:33 PM

    • State changed from “new” to “resolved”

    Merged in commit a5feaf0712002b09270ac3adab9a2d97e3a90a18

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Shared Ticket Bins

People watching this ticket

Attachments

Pages